Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain to v22 #3307

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Update toolchain to v22 #3307

merged 1 commit into from
Jan 22, 2025

Conversation

sapphire-arches
Copy link
Collaborator

Should reduce the Docker image size, and fixes formatting on OSX/Linux

Should reduce the Docker image size, and fixes formatting on OSX/Linux
Copy link
Contributor

Test Results

107 tests  ±0   107 ✅ ±0   1s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit 6de28b4. ± Comparison against base commit c3c3918.

@stellar-aria stellar-aria added this pull request to the merge queue Jan 22, 2025
Merged via the queue into community with commit c91a932 Jan 22, 2025
6 checks passed
m0nkmaster pushed a commit to m0nkmaster/DelugeFirmware that referenced this pull request Feb 1, 2025
Should reduce the Docker image size, and fixes formatting on OSX/Linux
github-merge-queue bot pushed a commit that referenced this pull request Feb 1, 2025
* Initial stab at trimming the start of audio

* Refactor audio clip view for improved marker handling and rendering

- Adjusted visibility logic for start and end markers to enhance user interaction.
- Updated rendering logic to differentiate between blinking and static marker states.
- Improved comments for clarity and maintenance.
- Implemented non-destructive start trimming functionality, allowing for better audio editing.
- Fixed minor issues related to marker toggling and display updates.

This commit builds upon the initial implementation of start trimming and enhances the overall user experience in the audio clip view.

* - Implemented non-destructive trimming functionality for start markers, allowing for more flexible audio editing.
- Fixed issues related to marker toggling.

TODO - Currently trimming from the start results in the prior audio becoming hidden and the new play head moves to column one. Should change this so the new playhead does not move and the hidden audio is greyed out.

* Button handling

* Restore button actions

* Put audio trim from start behind a feature flag

* Build tidy.

* improve audio clip marker handling

* Cleaned up formatting in settings.cpp and audio_clip_view.h

* Use predefined color constants.

* refactor: standardize AudioClip reference handling in audio_clip_view.cpp

* Refactor coloring code

* Add assignment operator to RGB class in rgb.h

* Refactor LED colour handling in waveform and pad LED rendering following recommended changes in audio_clip_view.

#3291 (comment)

* Formatting fixes.

* Update settings.cpp

* minor formatting fix

* Update toolchain to v22 (#3307)

Should reduce the Docker image size, and fixes formatting on OSX/Linux

* fix(audio): improve audio clip view null checks and recording state

- Add null checks for audio clip pointer
- Reinstated linear recording checks
- Clean up comments

* fix: restore macro handling in audio clip view

Restore macro activation functionality when clicking side column while holding
song button. This was accidentally removed during audio clip trimming changes.

* refactor(audio-clip): improve sample length handling restore comments

* refactor(audio-clip): improve sample length handling restore comments

* docs(rgb): improve assignment operator documentation

* feat(audio): add trim from start of audio clip feature documentation

Adds new feature setting to enable trimming from start of audio clips

* Update community features docs on start trimming

* Add reference to PR for start trimming

* Update community features docs on start trimming (2)

* Update community features docs on strart trimming

* Fix conflict

---------

Co-authored-by: Sapphire Koser <srkoser+GitHub@gmail.com>
Co-authored-by: Sean Ditny <138174805+seangoodvibes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants